netdev - Re: [bpf-next 00/10] samples/bpf: modernize BPF functionality test programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

[an error occurred while processing this directive]

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+zP5bkjkSa97k+dK7=NabkdoLWQtZ1qRwRTUQgGdqhVA@mail.gmail.com>
Date:   Sun, 15 Jan 2023 13:38:13 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     "Daniel T. Lee" <danieltimlee@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Yonghong Song <yhs@...com>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [bpf-next 00/10] samples/bpf: modernize BPF functionality test programs

On Sat, Jan 14, 2023 at 11:16 PM Daniel T. Lee <danieltimlee@...il.com> wrote:
>
> Currently, there are many programs under samples/bpf to test the
> various functionality of BPF that have been developed for a long time.
> However, the kernel (BPF) has changed a lot compared to the 2016 when
> some of these test programs were first introduced.
>
> Therefore, some of these programs use the deprecated function of BPF,
> and some programs no longer work normally due to changes in the API.
>
> To list some of the kernel changes that this patch set is focusing on,
> - legacy BPF map declaration syntax support had been dropped [1]
> - bpf_trace_printk() always append newline at the end [2]
> - deprecated styled BPF section header (bpf_load style) [3]
> - urandom_read tracepoint is removed (used for testing overhead) [4]
> - ping sends packet with SOCK_DGRAM instead of SOCK_RAW [5]*
> - use "vmlinux.h" instead of including individual headers
>
> In addition to this, this patchset tries to modernize the existing
> testing scripts a bit. And for network-related testing programs,
> a separate header file was created and applied. (To use the
> Endianness conversion function from xdp_sample and bunch of constants)

Nice set of cleanups. Applied.
As a follow up could you convert some of them to proper selftests/bpf ?
Unfortunately samples/bpf will keep bit rotting despite your herculean efforts.