netdev - Re: [Patch net v3 0/2] l2tp: fix race conditions in l2tp_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230116113844.GA14720@katalix.com>
Date:   Mon, 16 Jan 2023 11:38:44 +0000
From:   Tom Parkin <tparkin@...alix.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, saeed@...nel.org, gnault@...hat.com,
        Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch net v3 0/2] l2tp: fix race conditions in
 l2tp_tunnel_register()

On  Fri, Jan 13, 2023 at 19:01:35 -0800, Cong Wang wrote:
> From: Cong Wang <cong.wang@...edance.com>
> 
> This patchset contains two patches, the first one is a preparation for
> the second one which is the actual fix. Please find more details in
> each patch description.
> 
> I have ran the l2tp test (https://github.com/katalix/l2tp-ktest),
> all test cases are passed.
> 
> ---
> v3: preserve EEXIST errno for user-space
> v2: move IDR allocation to l2tp_tunnel_register()
> 
> Cong Wang (2):
>   l2tp: convert l2tp_tunnel_list to idr
>   l2tp: close all race conditions in l2tp_tunnel_register()
> 
>  net/l2tp/l2tp_core.c | 105 +++++++++++++++++++++----------------------
>  1 file changed, 52 insertions(+), 53 deletions(-)
> 
> -- 
> 2.34.1
> 

Thanks Cong, this looks good to me now.

Reviewed-by: Tom Parkin <tparkin@...alix.com>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)