netdev - Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Jan 2023 15:31:19 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     yang.yang29@....com.cn, aspriel@...il.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        sha-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xu.panda@....com.cn
Subject: Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()

On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote:
> <yang.yang29@....com.cn> wrote:
> 
> > From: Xu Panda <xu.panda@....com.cn>
> > 
> > The implementation of strscpy() is more robust and safer.
> > That's now the recommended way to copy NUL-terminated strings.
> > 
> > Signed-off-by: Xu Panda <xu.panda@....com.cn>
> > Signed-off-by: Yang Yang <yang.yang29@....com>
> 
> Mismatch email in From and Signed-off-by lines:
> 
> From: <yang.yang29@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>
> 
> Patch set to Changes Requested.

Kalle, please be aware of this response
https://lore.kernel.org/netdev/20230113112817.623f58fa@kernel.org/

"I don't trust that you know what you're doing. So please don't send
any more strncpy() -> strscpy() conversions for networking."

Thanks

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/patch/202212231037210142246@zte.com.cn/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>