netdev - Re: [PATCH v1 05/20] ARM: dts: imx6qdl: use enet_clk_ref instead of enet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230116052622.GA980@pengutronix.de>
Date:   Mon, 16 Jan 2023 06:26:22 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Peng Fan <peng.fan@....nxp.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Abel Vesa <abelvesa@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Richard Cochran <richardcochran@...il.com>,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        Lee Jones <lee@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, NXP Linux Team <linux-imx@....com>,
        kernel@...gutronix.de, Fabio Estevam <festevam@...il.com>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH v1 05/20] ARM: dts: imx6qdl: use enet_clk_ref instead of
 enet_out for the FEC node

On Mon, Jan 16, 2023 at 09:01:08AM +0800, Peng Fan wrote:
> Hi Oleksij,
> 
> On 1/13/2023 10:27 PM, Oleksij Rempel wrote:
> > Old imx6q machine code makes RGMII/RMII clock direction decision based on
> > configuration of "ptp" clock. "enet_out" is not used and make no real
> > sense, since we can't configure it as output or use it as clock
> > provider.
> > 
> > Instead of "enet_out" use "enet_clk_ref" which is actual selector to
> > choose between internal and external clock source:
> > 
> > FEC MAC <---------- enet_clk_ref <--------- SoC PLL
> >                           \
> > 			  ^------<-> refclock PAD (bi directional)
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >   arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> > index ff1e0173b39b..71522263031a 100644
> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> > @@ -1050,8 +1050,8 @@ fec: ethernet@...8000 {
> >   				clocks = <&clks IMX6QDL_CLK_ENET>,
> >   					 <&clks IMX6QDL_CLK_ENET>,
> >   					 <&clks IMX6QDL_CLK_ENET_REF>,
> > -					 <&clks IMX6QDL_CLK_ENET_REF>;
> > -				clock-names = "ipg", "ahb", "ptp", "enet_out";
> > +					 <&clks IMX6QDL_CLK_ENET_REF_SEL>;
> > +				clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
> 
> 
> Please also update fec binding, otherwise there will be dtbs check error.

Hm, there is no restriction on enet_clk_ref use or requirements to use
enet_out in Documentation/devicetree/bindings/net/fsl,fec.yaml

Do I missing something?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |