netdev - RE: [PATCH net-next 1/1] ice: use GNSS subsystem instead of TTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB4657338804C682B6A1EBF1499BC19@DM6PR11MB4657.namprd11.prod.outlook.com>
Date:   Mon, 16 Jan 2023 17:03:39 +0000
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "johan@...nel.org" <johan@...nel.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "Kolacinski, Karol" <karol.kolacinski@...el.com>,
        "Michalik, Michal" <michal.michalik@...el.com>,
        "G, GurucharanX" <gurucharanx.g@...el.com>
Subject: RE: [PATCH net-next 1/1] ice: use GNSS subsystem instead of TTY

>From: Greg KH <gregkh@...uxfoundation.org>
>Sent: Saturday, January 14, 2023 8:03 AM
>To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
>
>On Fri, Jan 13, 2023 at 01:48:52PM -0800, Tony Nguyen wrote:
>> From: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
>>
>> Previously support for GNSS was implemented as a TTY driver, it allowed
>> to access GNSS receiver on /dev/ttyGNSS_<bus><func>.
>>
>> Use generic GNSS subsystem API instead of implementing own TTY driver.
>> The receiver is accessible on /dev/gnss<id>. In case of multiple
>> receivers in the OS, correct device can be found by enumerating either:
>> - /sys/class/net/<eth port>/device/gnss/
>> - /sys/class/gnss/gnss<id>/device/
>
>You are saying what you are doing, but not anything about _why_ this
>change is the correct one.
>
>You are also breaking a user/kernel api here, how is existing users
>going to handle the tty device node going away?  What userspace tools
>are going to break and how are you going to handle that?
>
>While overall I like the idea here, you aren't really providing any
>justification for it at all.
>
>thanks,
>
>greg k-h

Sure, going to fix/explain it better.

Thank you!
Arkadiusz