netdev - Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87358bat16.fsf@kernel.org>
Date:   Mon, 16 Jan 2023 08:32:37 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Lizhe <sensor1010@....com>, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, johannes.berg@...el.com,
        alexander@...zel-home.de, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm_kzalloc replaces kmalloc

Eric Dumazet <edumazet@...gle.com> writes:

> On Fri, Jan 13, 2023 at 2:35 PM Lizhe <sensor1010@....com> wrote:
>>
>> use devm_kzalloc replaces kamlloc
>>
>> Signed-off-by: Lizhe <sensor1010@....com>
>> ---
>>  drivers/net/wireless/atmel/at76c50x-usb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
>> index 009bca34ece3..ebd8ef525557 100644
>> --- a/drivers/net/wireless/atmel/at76c50x-usb.c
>> +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
>> @@ -2444,7 +2444,7 @@ static int at76_probe(struct usb_interface *interface,
>>
>>         udev = usb_get_dev(interface_to_usbdev(interface));
>>
>> -       fwv = kmalloc(sizeof(*fwv), GFP_KERNEL);
>> +       fwv = devm_kzalloc(sizeof(*fwv), GFP_KERNEL);
>
> Have you compiled this patch ?

Clearly not:

https://lore.kernel.org/linux-wireless/202301140533.jMlST9Ur-lkp@intel.com/

Lizhe, do not EVER submit untested patches. In some simple patches doing
just a compilation test might suffice, but please mention the patch is
only compile tested clearly in the commit log. But not even doing a
compilation test is a big no.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches