netdev - Re: [PATCH net 1/2] net: dsa: microchip: ksz9477: port map correction in ALU table entry register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Jan 2023 22:59:45 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@...rochip.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        arun.ramadoss@...rochip.com, hkallweit1@...il.com,
        linux@...linux.org.uk
Subject: Re: [PATCH net 1/2] net: dsa: microchip: ksz9477: port map
 correction in ALU table entry register

On Mon, Jan 16, 2023 at 03:34:59PM +0530, Rakesh Sankaranarayanan wrote:
> ALU table entry 2 register in KSZ9477 have bit positions reserved for
> forwarding port map. This field is referred in ksz9477_fdb_del() for
> clearing forward port map and alu table.
> 
> But current fdb_del refer ALU table entry 3 register for accessing forward
> port map. Update ksz9477_fdb_del() to get forward port map from correct
> alu table entry register.
> 
> With this bug, issue can be observed while deleting static MAC entries.
> Delete any specific MAC entry using "bridge fdb del" command. This should
> clear all the specified MAC entries. But it is observed that entries with
> self static alone are retained.
> 
> Tested on LAN9370 EVB since ksz9477_fdb_del() is used common across
> LAN937x and KSZ series.
> 
> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
> Signed-off-by: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@...rochip.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>

Would be nice to convert the alu_table[] array into a proper structure
in a net-next patch.