[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y8aNt9YB9irSVXNo@unreal>
Date: Tue, 17 Jan 2023 13:59:51 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Chaitanya Kulkarni <chaitanyak@...dia.com>
Cc: Jason Gunthorpe <jgg@...dia.com>,
Israel Rukshin <israelr@...dia.com>,
Bryan Tan <bryantan@...are.com>,
Christoph Hellwig <hch@....de>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Jens Axboe <axboe@...com>,
Keith Busch <kbusch@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"linux-trace-kernel@...r.kernel.org"
<linux-trace-kernel@...r.kernel.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
Max Gurtovoy <mgurtovoy@...dia.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Paolo Abeni <pabeni@...hat.com>,
Saeed Mahameed <saeedm@...dia.com>,
Sagi Grimberg <sagi@...mberg.me>,
Selvin Xavier <selvin.xavier@...adcom.com>,
Steven Rostedt <rostedt@...dmis.org>,
Vishnu Dasa <vdasa@...are.com>,
Yishai Hadas <yishaih@...dia.com>
Subject: Re: [PATCH rdma-next 11/13] nvme: Introduce a local variable
On Tue, Jan 17, 2023 at 12:32:59AM +0000, Chaitanya Kulkarni wrote:
> On 1/16/23 05:05, Leon Romanovsky wrote:
> > From: Israel Rukshin <israelr@...dia.com>
> >
> > The patch doesn't change any logic.
> >
> > Signed-off-by: Israel Rukshin <israelr@...dia.com>
> > Signed-off-by: Leon Romanovsky <leon@...nel.org>
> > ---
> > drivers/nvme/host/core.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> > index 7be562a4e1aa..51a9880db6ce 100644
> > --- a/drivers/nvme/host/core.c
> > +++ b/drivers/nvme/host/core.c
> > @@ -1870,6 +1870,7 @@ static void nvme_update_disk_info(struct gendisk *disk,
> > sector_t capacity = nvme_lba_to_sect(ns, le64_to_cpu(id->nsze));
> > unsigned short bs = 1 << ns->lba_shift;
> > u32 atomic_bs, phys_bs, io_opt = 0;
> > + struct nvme_ctrl *ctrl = ns->ctrl;
> >
>
> I don't think this patch is needed, existing code is more readable and
> gives much clarity that we are accessing ctrl from namespace since we
> are in nvme_update_disk_info() which is namespace based.
I don't have strong opinion here.
Thanks
>
> -ck
>
Powered by blists - more mailing lists