netdev - RE: [PATCH linux-next] atm: lanai: Use dma_zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <913000213dd14e3b9da69270134aafa3@AcuMS.aculab.com>
Date:   Tue, 17 Jan 2023 15:37:43 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'ye.xingchen@....com.cn'" <ye.xingchen@....com.cn>,
        "3chas3@...il.com" <3chas3@...il.com>
CC:     "linux-atm-general@...ts.sourceforge.net" 
        <linux-atm-general@...ts.sourceforge.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent()

From: ye.xingchen@....com.cn
> Sent: 17 January 2023 09:21
> 
> Instead of using dma_alloc_coherent() and memset() directly use
> dma_zalloc_coherent().

I'm sure I've a brain cell that remembers that dma_alloc_coherent()
always zeros the buffer.
So the 'zalloc' variant isn't needed and the memset() can just
be deleted.
OTOH is it really worth the churn.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)