netdev - Re: [PATCH net-next v2 3/7] netfilter: flowtable: allow unidirectional rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a62hcbjm.fsf@nvidia.com>
Date:   Tue, 17 Jan 2023 19:31:45 +0200
From:   Vlad Buslov <vladbu@...dia.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <pablo@...filter.org>, <netdev@...r.kernel.org>,
        <netfilter-devel@...r.kernel.org>, <jhs@...atatu.com>,
        <xiyou.wangcong@...il.com>, <jiri@...nulli.us>, <ozsh@...dia.com>,
        <simon.horman@...igine.com>
Subject: Re: [PATCH net-next v2 3/7] netfilter: flowtable: allow
 unidirectional rules

On Tue 17 Jan 2023 at 12:15, Marcelo Ricardo Leitner <marcelo.leitner@...il.com> wrote:
> On Fri, Jan 13, 2023 at 05:55:44PM +0100, Vlad Buslov wrote:
>> Modify flow table offload to support unidirectional connections by
>> extending enum nf_flow_flags with new "NF_FLOW_HW_BIDIRECTIONAL" flag. Only
>> offload reply direction when the flag is not set. This infrastructure
>                                            ^^^ s///, I believe? :-)

Good catch!

>
> ...
>> -	ok_count += flow_offload_tuple_add(offload, flow_rule[1],
>> -					   FLOW_OFFLOAD_DIR_REPLY);
>> +	if (test_bit(NF_FLOW_HW_BIDIRECTIONAL, &offload->flow->flags))
>> +		ok_count += flow_offload_tuple_add(offload, flow_rule[1],
>> +						   FLOW_OFFLOAD_DIR_REPLY);
>>  	if (ok_count == 0)