netdev - Re: [PATCH net] net: sched: gred: prevent races when adding offloads to stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230117111019.50c47ea1@kernel.org>
Date:   Tue, 17 Jan 2023 11:10:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Cong Wang <xiyou.wangcong@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org, edumazet@...gle.com,
        Linux Kernel Functional Testing <lkft@...aro.org>,
        jhs@...atatu.com, jiri@...nulli.us, john.hurley@...ronome.com
Subject: Re: [PATCH net] net: sched: gred: prevent races when adding
 offloads to stats

On Tue, 17 Jan 2023 10:00:56 +0100 Paolo Abeni wrote:
> On Sat, 2023-01-14 at 18:20 -0800, Cong Wang wrote:
> > On Thu, Jan 12, 2023 at 08:41:37PM -0800, Jakub Kicinski wrote:  
> > > Naresh reports seeing a warning that gred is calling
> > > u64_stats_update_begin() with preemption enabled.
> > > Arnd points out it's coming from _bstats_update().  
> > 
> > The stack trace looks confusing to me without further decoding.
> > 
> > Are you sure we use sch->qstats/bstats in __dev_queue_xmit() there
> > not any netdev stats? It may be a false positive one as they may end up
> > with the same lockdep class.  

I didn't repro this myself, TBH, but there is u64_stats_update_begin() 
inside _bstats_update(). Pretty sure it will trigger the warning that
preemption is not disabled on non-SMP systems.

> I'm unsure I read you comment correctly. Please note that the
> referenced message includes several splats. The first one - arguably
> the most relevant - points to the lack of locking in the gred control
> path.

Yup, I'm not really sure if we're fixing the right splat for the bug.
But I am fairly confident we should be holding a lock while writing
bstats from the dump path, enqueue/dequeue may run concurrently.

> The posted patch LGTM, could you please re-phrase your doubts?