netdev - Re: [PATCH net-next v1 1/7] net: flow_offload: provision conntrack info in ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8ZUa+uiXWAklNem@corigine.com>
Date:   Tue, 17 Jan 2023 08:55:23 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        pablo@...filter.org, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, ozsh@...dia.com,
        marcelo.leitner@...il.com,
        Baowen Zheng <baowen.zheng@...igine.com>,
        oss-drivers@...igine.com
Subject: Re: [PATCH net-next v1 1/7] net: flow_offload: provision conntrack
 info in ct_metadata

On Fri, Jan 13, 2023 at 06:15:55PM +0200, Vlad Buslov wrote:
> On Fri 13 Jan 2023 at 10:12, Simon Horman <simon.horman@...igine.com> wrote:
> > + Baowen Zheng, oss-drivers@...igine.com

...

> > Hi Vlad,
> >
> > Some feedback from Baowen Zheng, who asked me to pass it on here:
> >
> >   It is confusing that after FLOW_ACTION_CT_METADATA check, this functoin
> >   will return false, that is -EOPNOTSUPP.
> >
> >   Since this function is only used to check nft table, It seems better to
> >   change its name to nfp_fl_ct_offload_nft_supported(). This would make things
> >   clearer and may avoid it being used in the wrong way.
> 
> Thanks for the suggestions! I will change the naming and send V2.

Thanks Vlad, much appreciated.