netdev - Re: [PATCH net-next] net: dsa: microchip: ptp: Fix error code in ksz_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230118104414.2tvgqr4edjw32e3o@skbuf>
Date:   Wed, 18 Jan 2023 12:44:14 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Dan Carpenter <error27@...il.com>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        Christian Eggers <ceggers@...i.de>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Richard Cochran <richardcochran@...il.com>,
        Arun Ramadoss <arun.ramadoss@...rochip.com>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: microchip: ptp: Fix error code in
 ksz_hwtstamp_set()

On Wed, Jan 18, 2023 at 01:28:21PM +0300, Dan Carpenter wrote:
> We want to return negative error codes here but the copy_to/from_user()
> functions return the number of bytes remaining to be copied.
> 
> Fixes: c59e12a140fb ("net: dsa: microchip: ptp: Initial hardware time stamping support")
> Signed-off-by: Dan Carpenter <error27@...il.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>