[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y8fo6qx7LnXsJN4o@corigine.com>
Date: Wed, 18 Jan 2023 13:41:14 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Jerome Brunet <jbrunet@...libre.com>, netdev@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
linux-amlogic@...ts.infradead.org,
Kevin Hilman <khilman@...libre.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Da Xue <da@...sconfused.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support
On Wed, Jan 18, 2023 at 03:56:32AM +0100, Andrew Lunn wrote:
> > > >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > > >> + if (!priv)
> > > >> + return -ENOMEM;
> > > >
> > > > nit: may be it is nicer to use dev_err_probe() here for consistency.
> > >
> > > That was on purpose. I only use the `dev_err_probe()` when the probe may
> > > defer, which I don't expect here.
> > >
> > > I don't mind changing if you prefer it this way.
> >
> > I have no strong opinion on this :)
>
> dev_err_probe() does not apply here, because devm_kzalloc does not
> return an error code. Hence it cannot be EPROBE_DEFFER, which is what
> dev_err_probe() is looking for.
Sure, there is no EPROBE_DEFFER.
But, FWIIW, my reading of the documentation for dev_err_probe()
is that it's use in such cases is acceptable.
Anyway, let's pass on my suggestion.
Powered by blists - more mailing lists