netdev - Re: [patch net-next v5 11/12] devlink: remove devlink_dump_for_each_instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90532340-ad5e-38a8-55e6-55faee63698b@intel.com>
Date:   Wed, 18 Jan 2023 13:24:09 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <michael.chan@...adcom.com>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
        <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <tariqt@...dia.com>, <saeedm@...dia.com>, <leon@...nel.org>,
        <idosch@...dia.com>, <petrm@...dia.com>,
        <mailhol.vincent@...adoo.fr>, <gal@...dia.com>
Subject: Re: [patch net-next v5 11/12] devlink: remove
 devlink_dump_for_each_instance_get() helper



On 1/18/2023 7:21 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> devlink_dump_for_each_instance_get() is currently called from
> a single place in netlink.c. As there is no need to use
> this helper anywhere else in the future, remove it and
> call devlinks_xa_find_get() directly from while loop
> in devlink_nl_instance_iter_dump(). Also remove redundant
> idx clear on loop end as it is already done
> in devlink_nl_instance_iter_dump().
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Nice cleanup considering that the function has a comment about how its
not a generic iterator.. Less chance of accidentally misusing it in the
future.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>