netdev - Re: [net-next 09/15] net/mlx5e: TC, Add tc prefix to attach/detach hdr functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d66261bf-d3f8-3a32-09dc-2dc6e88a783c@intel.com>
Date:   Wed, 18 Jan 2023 13:44:11 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
CC:     Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>, Roi Dayan <roid@...dia.com>,
        Maor Dickman <maord@...dia.com>
Subject: Re: [net-next 09/15] net/mlx5e: TC, Add tc prefix to attach/detach
 hdr functions



On 1/18/2023 10:35 AM, Saeed Mahameed wrote:
> From: Roi Dayan <roid@...dia.com>
> 
> Currently there are confusing names for attach/detach functions.
> 
> mlx5e_attach_mod_hdr() vs mlx5e_mod_hdr_attach()
> mlx5e_detach_mod_hdr() vs mlx5e_mod_hdr_detach()
> 
> Add tc prefix to the functions that are in en_tc.c to separate
> from the functions in mod_hdr.c which has the mod_hdr prefix.
> 

Makes it a bit easier to distinguish the pairs.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>