netdev - Re: [PATCH net] tcp: fix rate_app

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJNZ8K7=NjwQE4TnSFgfj=2OWGnk3ozqVbPR=nXnw=56g@mail.gmail.com>
Date:   Thu, 19 Jan 2023 20:28:38 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Morley <morleyd.kernel@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        David Morley <morleyd@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH net] tcp: fix rate_app_limited to default to 1

On Thu, Jan 19, 2023 at 8:00 PM David Morley <morleyd.kernel@...il.com> wrote:
>
> From: David Morley <morleyd@...gle.com>
>
> The initial default value of 0 for tp->rate_app_limited was incorrect,
> since a flow is indeed application-limited until it first sends
> data. Fixing the default to be 1 is generally correct but also
> specifically will help user-space applications avoid using the initial
> tcpi_delivery_rate value of 0 that persists until the connection has
> some non-zero bandwidth sample.
>
> Fixes: eb8329e0a04d ("tcp: export data delivery rate")
> Suggested-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: David Morley <morleyd@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Tested-by: David Morley <morleyd@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.