netdev - RE: [PATCH net-next 14/15] ice: Introduce local var for readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Jan 2023 22:34:33 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Tony Nguyen' <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: RE: [PATCH net-next 14/15] ice: Introduce local var for readability

From: Tony Nguyen
> Sent: 19 January 2023 21:28
> 
> Based on previous feedback[1], introduce a local var to make things more
> readable.
> 
> [1] https://lore.kernel.org/netdev/20220315203218.607f612b@kicinski-fedora-
> pc1c0hjn.dhcp.thefacebook.com/
...
> -	mutex_destroy(&(&pf->hw)->fdir_fltr_lock);
> +	mutex_destroy(&hw->fdir_fltr_lock);

The 'uncrazy' version is:
	mutex_destroy(&pf->hw.fdir_fltr_lock);

No need for a local.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)