netdev - Re: [PATCH net] net/ulp: use consistent error code when blocking ULP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8kUSPZSEOE57reb@hog>
Date:   Thu, 19 Jan 2023 10:58:32 +0100
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net] net/ulp: use consistent error code when blocking ULP

2023-01-18, 13:24:12 +0100, Paolo Abeni wrote:
> The referenced commit changed the error code returned by the kernel
> when preventing a non-established socket from attaching the ktls
> ULP. Before to such a commit, the user-space got ENOTCONN instead
> of EINVAL.
> 
> The existing self-tests depend on such error code, and the change
> caused a failure:
> 
>   RUN           global.non_established ...
>  tls.c:1673:non_established:Expected errno (22) == ENOTCONN (107)
>  non_established: Test failed at step #3
>           FAIL  global.non_established
> 
> In the unlikely event existing applications do the same, address
> the issue by restoring the prior error code in the above scenario.
> 
> Note that the only other ULP performing similar checks at init
> time - smc_ulp_ops - also fails with ENOTCONN when trying to attach
> the ULP to a non-established socket.
> 
> Reported-by: Sabrina Dubroca <sd@...asysnail.net>
> Fixes: 2c02d41d71f9 ("net/ulp: prevent ULP without clone op from entering the LISTEN status")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks Paolo.

-- 
Sabrina