netdev - Re: [PATCH net-next v3 3/8] net: add basic C code generators for Netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <210590039104c51e5b3ffbc3166807cc4617bb92.camel@sipsolutions.net>
Date:   Fri, 20 Jan 2023 10:17:19 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, robh@...nel.org, stephen@...workplumber.org,
        ecree.xilinx@...il.com, sdf@...gle.com, f.fainelli@...il.com,
        fw@...len.de, linux-doc@...r.kernel.org, razor@...ckwall.org,
        nicolas.dichtel@...nd.com
Subject: Re: [PATCH net-next v3 3/8] net: add basic C code generators for
 Netlink

On Thu, 2023-01-19 at 17:53 -0800, Jakub Kicinski wrote:
> 
> > Doesn't look that bad overall, IMHO. :)
> 
> I hope we can avoid over-focusing on the python tools :P

Oh sure.

> I'm no python expert and the code would use a lot of refactoring.
> But there's only so many hours in the day and the alternative
> seems that it will bit rot in my tree forever :(
> 
:)

Yeah I don't mind. The quality of the implementation matters to a point,
but honestly I was just reading through this to convince myself it
wasn't just a totally stinking pile of hacks ;-) Which you/I have
managed, so personally I'm happy with this.

johannes