[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8c43b018-8979-e93b-cc19-76de6f8b60d1@gmail.com>
Date: Fri, 20 Jan 2023 10:12:01 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>,
Jakub Kicinski <kuba@...nel.org>,
Woojung Huh <woojung.huh@...rochip.com>,
UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Oleksij Rempel <linux@...pel-privat.de>
Cc: kernel@...gutronix.de, ore@...gutronix.de,
Arun.Ramadoss@...rochip.com, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: dsa: microchip: fix probe of I2C-connected
KSZ8563
On 1/20/2023 3:09 AM, Ahmad Fatoum wrote:
> Starting with commit eee16b147121 ("net: dsa: microchip: perform the
> compatibility check for dev probed"), the KSZ switch driver now bails
> out if it thinks the DT compatible doesn't match the actual chip ID
> read back from the hardware:
>
> ksz9477-switch 1-005f: Device tree specifies chip KSZ9893 but found
> KSZ8563, please fix it!
>
> For the KSZ8563, which used ksz_switch_chips[KSZ9893], this was fine
> at first, because it indeed shares the same chip id as the KSZ9893.
>
> Commit b44908095612 ("net: dsa: microchip: add separate struct
> ksz_chip_data for KSZ8563 chip") started differentiating KSZ9893
> compatible chips by consulting the 0x1F register. The resulting breakage
> was fixed for the SPI driver in the same commit by introducing the
> appropriate ksz_switch_chips[KSZ8563], but not for the I2C driver.
>
> Fix this for I2C-connected KSZ8563 now to get it probing again.
>
> Fixes: b44908095612 ("net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563 chip").
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists