netdev - Re: [PATCH net 1/2] net: ravb: Fix lack of register setting after system resumed for Gen3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b467103-6afc-171d-1293-cedebf64d878@omp.ru>
Date:   Fri, 20 Jan 2023 22:47:23 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>
CC:     <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH net 1/2] net: ravb: Fix lack of register setting after
 system resumed for Gen3

On 1/19/23 7:39 AM, Yoshihiro Shimoda wrote:

> After system entered Suspend to RAM, registers setting of this
> hardware is resetted because the SoC will be turned off. On R-Car Gen3

   s/resetted/reset/.

> (info->ccc_gac), ravb_ptp_init() is called in ravb_probe() only. So,
> after system resumed, it lacks of the initial settings for ptp. So,
> add ravb_ptp_{init,stop}() into ravb_{resume,suspend}().
> 
> Fixes: f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey