netdev - Re: [PATCH bpf-next v8 16/17] net/mlx5e: Support RX XDP metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a89e9e55-d203-e7de-6aaa-ac8658001276@linux.dev>
Date:   Fri, 20 Jan 2023 14:37:29 -0800
From:   Martin KaFai Lau <martin.lau@...ux.dev>
To:     Tariq Toukan <tariqt@...dia.com>
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, haoluo@...gle.com, jolsa@...nel.org,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        David Ahern <dsahern@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Anatoly Burakov <anatoly.burakov@...el.com>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH bpf-next v8 16/17] net/mlx5e: Support RX XDP metadata

On 1/19/23 2:15 PM, Stanislav Fomichev wrote:
> From: Toke Høiland-Jørgensen <toke@...hat.com>
> 
> Support RX hash and timestamp metadata kfuncs. We need to pass in the cqe
> pointer to the mlx5e_skb_from* functions so it can be retrieved from the
> XDP ctx to do this.

Tariq, I believe Stan and Toke have addressed your comments in v7 on the mlx5 
changes. I have also tested in my mlx5 setup with the xdp_hw_metadata in patch 
17. Please help to take a look at patch 15, 16, and ack them if they look good 
to you also.