netdev - Re: [PATCH net-next v3 1/8] docs: add more netlink docs (incl. spec docs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dd6c9bf-192d-44ab-7d93-22c01cb8d64b@intel.com>
Date:   Thu, 19 Jan 2023 16:23:02 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Johannes Berg <johannes@...solutions.net>,
        Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <robh@...nel.org>,
        <stephen@...workplumber.org>, <ecree.xilinx@...il.com>,
        <sdf@...gle.com>, <f.fainelli@...il.com>, <fw@...len.de>,
        <linux-doc@...r.kernel.org>, <razor@...ckwall.org>,
        <nicolas.dichtel@...nd.com>, Bagas Sanjaya <bagasdotme@...il.com>
Subject: Re: [PATCH net-next v3 1/8] docs: add more netlink docs (incl. spec
 docs)



On 1/19/2023 12:29 PM, Johannes Berg wrote:
> On Wed, 2023-01-18 at 16:36 -0800, Jakub Kicinski wrote:
>> +kernel-policy
>> +~~~~~~~~~~~~~
>> +
>> +Defines if the kernel validation policy is per operation (``per-op``)
>> +or for the entire family (``global``). New families should use ``per-op``
>> +(default) to be able to narrow down the attributes accepted by a specific
>> +command.
> 
> Again I'm not sure I agree with that recommendation, but I know it's
> your preference :-)
> 
> (IMHO some things become more complex, such as having a "ifindex" in
> each one of them)
> 

Per op policy is important because otherwise it can become impossible to
safely extend a new attribute to commands over multiple kernel releases.

If you add an attribute like DEVLINK_ATTR_DRY_RUN in one kernel, and add
it to devlink_cmd_foo.. its no longer really possible to add it to
another command if the policy is global.