netdev - Re: [PATCH net-next v2 1/1] ice: use GNSS subsystem instead of TTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8lJ1QUkudGM8aR2@kroah.com>
Date:   Thu, 19 Jan 2023 14:47:01 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
        netdev@...r.kernel.org, johan@...nel.org, jirislaby@...nel.org,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Karol Kolacinski <karol.kolacinski@...el.com>,
        Michal Michalik <michal.michalik@...el.com>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next v2 1/1] ice: use GNSS subsystem instead of TTY

On Wed, Jan 18, 2023 at 04:58:36PM -0800, Tony Nguyen wrote:
> From: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
> 
> Previously support for GNSS was implemented as a TTY driver, it allowed
> to access GNSS receiver on /dev/ttyGNSS_<bus><func>.
> 
> Use generic GNSS subsystem API instead of implementing own TTY driver.
> The receiver is accessible on /dev/gnss<id>. In case of multiple receivers
> in the OS, correct device can be found by enumerating either:
> - /sys/class/net/<eth port>/device/gnss/
> - /sys/class/gnss/gnss<id>/device/
> 
> Using GNSS subsystem is superior to implementing own TTY driver, as the
> GNSS subsystem was designed solely for this purpose. It also implements
> TTY driver but in a common and defined way.
> 
> >From user perspective, there is no difference in communicating with a
> device, except new path to the device shall be used.

If you can handle the fallout from this, ok, that's on you :)

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>