[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1739f5ba-6d73-cd2c-d088-39428fdb55a7@kernel.org>
Date: Thu, 19 Jan 2023 12:27:25 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Siddharth Vadapalli <s-vadapalli@...com>, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, linux@...linux.org.uk,
pabeni@...hat.com, leon@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, vigneshr@...com, srk@...com
Subject: Re: [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts
driver
On 18/01/2023 11:54, Siddharth Vadapalli wrote:
> Delete unreachable code in am65_cpsw_init_cpts() function, which was
> Reported-by: Leon Romanovsky <leon@...nel.org>
> at:
> https://lore.kernel.org/r/Y8aHwSnVK9+sAb24@unreal
>
> Remove the devm action associated with am65_cpts_release() and invoke the
> function directly on the cleanup and exit paths.
>
> Changes from v2:
> 1. Drop Reviewed-by tag from Roger Quadros.
> 2. Add cleanup patch for deleting unreachable error handling code in
> am65_cpsw_init_cpts().
> 3. Drop am65_cpsw_cpts_cleanup() function and directly invoke
> am65_cpts_release().
>
> Changes from v1:
> 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This
> error was reported by kernel test robot <lkp@...el.com> at:
> https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/
> 2. Collect Reviewed-by tag from Roger Quadros.
>
> v2:
> https://lore.kernel.org/r/20230116044517.310461-1-s-vadapalli@ti.com/
> v1:
> https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/
>
> Siddharth Vadapalli (2):
> net: ethernet: ti: am65-cpsw: Delete unreachable error handling code
> net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
>
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 ++-----
> drivers/net/ethernet/ti/am65-cpts.c | 15 +++++----------
> drivers/net/ethernet/ti/am65-cpts.h | 5 +++++
> 3 files changed, 12 insertions(+), 15 deletions(-)
>
Reviewed-by: Roger Quadros <rogerq@...nel.org>
Powered by blists - more mailing lists