netdev - Re: [PATCH net-next v3 7/8] net: fou: use policy and operation tables generated from the spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230119170419.091f7a02@kernel.org>
Date:   Thu, 19 Jan 2023 17:04:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     Johannes Berg <johannes@...solutions.net>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <robh@...nel.org>,
        <stephen@...workplumber.org>, <ecree.xilinx@...il.com>,
        <sdf@...gle.com>, <f.fainelli@...il.com>, <fw@...len.de>,
        <linux-doc@...r.kernel.org>, <razor@...ckwall.org>,
        <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH net-next v3 7/8] net: fou: use policy and operation
 tables generated from the spec

On Thu, 19 Jan 2023 16:18:04 -0800 Jacob Keller wrote:
> On 1/19/2023 12:56 PM, Johannes Berg wrote:
> > On Wed, 2023-01-18 at 16:36 -0800, Jakub Kicinski wrote:  
> >> +fou-y := fou_core.o fou-nl.o  
> > 
> > I feel like you could've been consistent there and used "fou-core.o"
> > with a dash, but hey :-)
> 
> And here I lean towards using _ instead of - in file names but
> consistency is good, all else being equal.

Done. IIRC the codegen used to assume the naming (it needs to know 
the name of the header to include). I fixed that but forgot to rename
fou :S