netdev - Re: [PATCH net-next] net: microchip: vcap: use kmemdup() to allocate memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa74af113933cea071c1639a28ffefa7572f05a2.camel@microchip.com>
Date:   Fri, 20 Jan 2023 09:05:59 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Yang Yingliang <yangyingliang@...wei.com>, <netdev@...r.kernel.org>
CC:     <lars.povlsen@...rochip.com>, <daniel.machon@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: use kmemdup() to
 allocate memory

Hi Yang,

Thanks for the correction.

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

BR
Steen

On Thu, 2023-01-19 at 17:22 +0800, Yang Yingliang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Use kmemdup() helper instead of open-coding to simplify
> the code when allocating newckf and newcaf.
> 
> Generated by: scripts/coccinelle/api/memdup.cocci
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/net/ethernet/microchip/vcap/vcap_api.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c
> b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> index 71f787a78295..d9cf2cd1925a 100644
> --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c
> +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> @@ -1000,18 +1000,16 @@ static struct vcap_rule_internal *vcap_dup_rule(struct
> vcap_rule_internal *ri,
>                 return duprule;
> 
>         list_for_each_entry(ckf, &ri->data.keyfields, ctrl.list) {
> -               newckf = kzalloc(sizeof(*newckf), GFP_KERNEL);
> +               newckf = kmemdup(ckf, sizeof(*newckf), GFP_KERNEL);
>                 if (!newckf)
>                         return ERR_PTR(-ENOMEM);
> -               memcpy(newckf, ckf, sizeof(*newckf));
>                 list_add_tail(&newckf->ctrl.list, &duprule->data.keyfields);
>         }
> 
>         list_for_each_entry(caf, &ri->data.actionfields, ctrl.list) {
> -               newcaf = kzalloc(sizeof(*newcaf), GFP_KERNEL);
> +               newcaf = kmemdup(caf, sizeof(*newcaf), GFP_KERNEL);
>                 if (!newcaf)
>                         return ERR_PTR(-ENOMEM);
> -               memcpy(newcaf, caf, sizeof(*newcaf));
>                 list_add_tail(&newcaf->ctrl.list, &duprule-
> >data.actionfields);
>         }
> 
> --
> 2.25.1
>