netdev - Re: [PATCH bpf-next 1/7] netdev-genl: create a simple family for netdev stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y812VL/IJ5fjrDqI@lore-desk>
Date:   Sun, 22 Jan 2023 18:45:56 +0100
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Marek Majtyka <alardam@...il.com>,
        Saeed Mahameed <saeedm@...dia.com>, anthony.l.nguyen@...el.com,
        Andy Gospodarek <gospo@...adcom.com>, vladimir.oltean@....com,
        Felix Fietkau <nbd@....name>, john@...ozen.org,
        leon@...nel.org, Simon Horman <simon.horman@...igine.com>,
        Ariel Elior <aelior@...vell.com>,
        christophe.jaillet@...adoo.fr, ecree.xilinx@...il.com,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Björn Töpel <bjorn@...nel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        Niklas Söderlund 
        <niklas.soderlund@...igine.com>
Subject: Re: [PATCH bpf-next 1/7] netdev-genl: create a simple family for
 netdev stuff

On Jan 20, Alexei Starovoitov wrote:
> On Fri, Jan 20, 2023 at 9:17 AM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> > +
> > +#define NETDEV_XDP_ACT_BASIC           (NETDEV_XDP_ACT_DROP |  \
> > +                                        NETDEV_XDP_ACT_PASS |  \
> > +                                        NETDEV_XDP_ACT_TX |    \
> > +                                        NETDEV_XDP_ACT_ABORTED)
> 
> Why split it into 4?
> Is there a driver that does a subset?

nope, at least all drivers support NETDEV_XDP_ACT_BASIC. I guess we can squash
them and just add  NETDEV_XDP_ACT_BASIC.

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)