netdev - Re: [PATCH net-next v2 05/15] netlink: add macro for checking dump ctx size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y86XpbLnEpiNZzTL@shredder>
Date:   Mon, 23 Jan 2023 16:20:21 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jacob.e.keller@...el.com, jiri@...nulli.us,
        Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next v2 05/15] netlink: add macro for checking dump
 ctx size

On Wed, Jan 04, 2023 at 08:05:21PM -0800, Jakub Kicinski wrote:
> We encourage casting struct netlink_callback::ctx to a local
> struct (in a comment above the field). Provide a convenience
> macro for checking if the local struct fits into the ctx.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  include/linux/netlink.h              | 4 ++++
>  net/netfilter/nf_conntrack_netlink.c | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/netlink.h b/include/linux/netlink.h
> index d81bde5a5844..38f6334f408c 100644
> --- a/include/linux/netlink.h
> +++ b/include/linux/netlink.h
> @@ -263,6 +263,10 @@ struct netlink_callback {
>  	};
>  };
>  
> +#define NL_ASSET_DUMP_CTX_FITS(type_name)				\

Wanted to use this macro, but the name doesn't make sense to me. Should
it be NL_ASSERT_DUMP_CTX_FITS() ?

> +	BUILD_BUG_ON(sizeof(type_name) >				\
> +		     sizeof_field(struct netlink_callback, ctx))
> +
>  struct netlink_notify {
>  	struct net *net;
>  	u32 portid;
> diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
> index 1286ae7d4609..90672e293e57 100644
> --- a/net/netfilter/nf_conntrack_netlink.c
> +++ b/net/netfilter/nf_conntrack_netlink.c
> @@ -3866,7 +3866,7 @@ static int __init ctnetlink_init(void)
>  {
>  	int ret;
>  
> -	BUILD_BUG_ON(sizeof(struct ctnetlink_list_dump_ctx) > sizeof_field(struct netlink_callback, ctx));
> +	NL_ASSET_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
>  
>  	ret = nfnetlink_subsys_register(&ctnl_subsys);
>  	if (ret < 0) {
> -- 
> 2.38.1
>