netdev - Re: [PATCH net-next v4 2/2] selftests/net: Cover the IP_LOCAL_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230123175852.59621-1-kuniyu@amazon.com>
Date:   Mon, 23 Jan 2023 09:58:52 -0800
From:   Kuniyuki Iwashima <kuniyu@...zon.com>
To:     <jakub@...udflare.com>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>,
        <eparis@...isplace.org>, <kernel-team@...udflare.com>,
        <kuba@...nel.org>, <kuniyu@...zon.com>, <marek@...udflare.com>,
        <ncardwell@...gle.com>, <netdev@...r.kernel.org>,
        <pabeni@...hat.com>, <paul@...l-moore.com>,
        <selinux@...r.kernel.org>, <stephen.smalley.work@...il.com>
Subject: Re: [PATCH net-next v4 2/2] selftests/net: Cover the IP_LOCAL_PORT_RANGE socket option

From:   Jakub Sitnicki <jakub@...udflare.com>
Date:   Mon, 23 Jan 2023 15:44:40 +0100
> Exercise IP_LOCAL_PORT_RANGE socket option in various scenarios:
> 
> 1. pass invalid values to setsockopt
> 2. pass a range outside of the per-netns port range
> 3. configure a single-port range
> 4. exhaust a configured multi-port range
> 5. check interaction with late-bind (IP_BIND_ADDRESS_NO_PORT)
> 6. set then get the per-socket port range
> 
> v2 -> v3:
>  * Switch from CPP-based templates to FIXTURE_VARIANT. (Kuniyuki)
>  * Cover SOCK_STREAM/IPPROTO_SCTP where possible.
> 
> v1 -> v2:
>  * selftests: Instead of iterating over socket families (ip4, ip6) and types
>    (tcp, udp), generate tests for each combo from a template. This keeps the
>    code indentation level down and makes tests more granular.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>