netdev - Re: [PATCH v9 02/25] net/ethtool: add new stringset ETH_SS_ULP_DDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <253r0vlrtld.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Mon, 23 Jan 2023 20:31:10 +0200
From:   Aurelien Aptel <aaptel@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
        sagi@...mberg.me, hch@....de, kbusch@...nel.org, axboe@...com,
        chaitanyak@...dia.com, davem@...emloft.net,
        aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
        ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com
Subject: Re: [PATCH v9 02/25] net/ethtool: add new stringset
 ETH_SS_ULP_DDP_{CAPS,STATS}

Jakub Kicinski <kuba@...nel.org> writes:
> This should be in uAPI and used as attribute IDs.

Following the discussion from [1] ("you can add the dynamic string set
if you like.") we deliberately did not expose the enum to userspace so
that ethtool doesn't have to be updated or recompiled to list newer
kernel ULP DDP statistics.

Should we change this approach?

1: https://lore.kernel.org/netdev/20230111204644.040d0a9d@kernel.org/