netdev - Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKH8qBs=1NgpJBNwJg7dZQnSAAGpH4vJj0+=LNWuQamGFerfZw@mail.gmail.com>
Date:   Mon, 23 Jan 2023 10:55:52 -0800
From:   Stanislav Fomichev <sdf@...gle.com>
To:     Martin KaFai Lau <martin.lau@...ux.dev>
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, haoluo@...gle.com, jolsa@...nel.org,
        David Ahern <dsahern@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Anatoly Burakov <anatoly.burakov@...el.com>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs

On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau <martin.lau@...ux.dev> wrote:
>
> On 1/19/23 2:15 PM, Stanislav Fomichev wrote:
> > Please see the first patch in the series for the overall
> > design and use-cases.
> >
> > See the following email from Toke for the per-packet metadata overhead:
> > https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798
> >
> > Recent changes:
> > - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq)
> >
> > - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq)
> >
> > - Clarify xdp_buff vs 'XDP frame' (Jesper)
> >
> > - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper)
> >
> > - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead
> >    of ifname (due to recent xsk.h refactoring)
>
> Applied with the minor changes in the selftests discussed in patch 11 and 17.
> Thanks!

Awesome, thanks! I was gonna resend around Wed, but thank you for
taking care of that!