netdev - Re: [PATCH v4 0/4] wifi: libertas: IE handling fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2023 09:06:03 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Doug Brown <doug@...morgal.com>
Cc:     Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Dan Williams <dcbw@...hat.com>,
        libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v4 0/4] wifi: libertas: IE handling fixes

On Sun, Jan 22, 2023 at 09:31:28PM -0800, Doug Brown wrote:
> This series implements two fixes for the libertas driver that restore
> compatibility with modern wpa_supplicant versions, and adds (or at least
> improves) support for WPS in the process.
> 
> 1) Better handling of the RSN/WPA IE in association requests:
>    The previous logic was always just grabbing the first one, and didn't
>    handle multiple IEs properly, which wpa_supplicant adds nowadays.
> 
> 2) Support for IEs in scan requests:
>    Modern wpa_supplicant always adds an "extended capabilities" IE,
>    which violates max_scan_ie_len in this driver. Go ahead and allow
>    scan IEs, and handle WPS based on the info that Dan provided.
> 
> These changes have been tested on a Marvell PXA168-based device with a
> Marvell 88W8686 Wi-Fi chipset. I've confirmed that with these changes
> applied, modern wpa_supplicant versions connect properly and WPS also
> works correctly (tested with "wpa_cli -i wlan0 wps_pbc any").

Thanks,

this looks good to me. So, FWIIW,

Reviewed-by: Simon Horman <simon.horman@...igine.com>