netdev - Re: [PATCH net v2 2/2] net: ravb: Fix possible hang if RIS2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <912f5eb3-2905-c394-3239-506f8bc9f764@omp.ru>
Date:   Mon, 23 Jan 2023 22:41:05 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>
CC:     <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH net v2 2/2] net: ravb: Fix possible hang if RIS2_QFF1
 happen

Hello!

On 1/23/23 4:13 PM, Yoshihiro Shimoda wrote:

> Since this driver enables the interrupt by RIC2_QFE1, this driver
> should clear the interrupt flag if it happens. Otherwise, the interrupt
> causes to hang the system.
> 
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 3f61100c02f4..0f54849a3823 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1101,14 +1101,14 @@ static void ravb_error_interrupt(struct net_device *ndev)
>  	ravb_write(ndev, ~(EIS_QFS | EIS_RESERVED), EIS);
>  	if (eis & EIS_QFS) {
>  		ris2 = ravb_read(ndev, RIS2);
> -		ravb_write(ndev, ~(RIS2_QFF0 | RIS2_RFFF | RIS2_RESERVED),
> +		ravb_write(ndev, ~(RIS2_QFF0 | RIS2_QFF1 | RIS2_RFFF | RIS2_RESERVED),
>  			   RIS2);
>  
>  		/* Receive Descriptor Empty int */
>  		if (ris2 & RIS2_QFF0)
>  			priv->stats[RAVB_BE].rx_over_errors++;
>  
> -		    /* Receive Descriptor Empty int */
> +		/* Receive Descriptor Empty int */

   Well, that should've been noted in the commit log...

[...]

MBR, Sergey