netdev - Re: [PATCH v2 04/13] iio: imu: Replace all spi->chip_select and spi->cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2023 13:47:04 +0100
From:   Michal Simek <michal.simek@....com>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
        <broonie@...nel.org>, <miquel.raynal@...tlin.com>,
        <richard@....at>, <vigneshr@...com>, <jic23@...nel.org>,
        <tudor.ambarus@...rochip.com>, <pratyush@...nel.org>,
        <sanju.mehta@....com>, <chin-ting_kuo@...eedtech.com>,
        <clg@...d.org>, <kdasu.kdev@...il.com>, <f.fainelli@...il.com>,
        <rjui@...adcom.com>, <sbranden@...adcom.com>,
        <eajames@...ux.ibm.com>, <olteanv@...il.com>, <han.xu@....com>,
        <john.garry@...wei.com>, <shawnguo@...nel.org>,
        <s.hauer@...gutronix.de>, <narmstrong@...libre.com>,
        <khilman@...libre.com>, <matthias.bgg@...il.com>,
        <haibo.chen@....com>, <linus.walleij@...aro.org>,
        <daniel@...que.org>, <haojian.zhuang@...il.com>,
        <robert.jarzmik@...e.fr>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <heiko@...ech.de>,
        <krzysztof.kozlowski@...aro.org>, <andi@...zian.org>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...s.st.com>,
        <wens@...e.org>, <jernej.skrabec@...il.com>, <samuel@...lland.org>,
        <masahisa.kojima@...aro.org>, <jaswinder.singh@...aro.org>,
        <rostedt@...dmis.org>, <mingo@...hat.com>,
        <l.stelmach@...sung.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <alex.aring@...il.com>, <stefan@...enfreihafen.org>,
        <kvalo@...nel.org>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>, <skomatineni@...dia.com>,
        <sumit.semwal@...aro.org>, <christian.koenig@....com>,
        <j.neuschaefer@....net>, <vireshk@...nel.org>, <rmfrfs@...il.com>,
        <johan@...nel.org>, <elder@...nel.org>,
        <gregkh@...uxfoundation.org>
CC:     <git@....com>, <linux-spi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <joel@....id.au>,
        <andrew@...id.au>, <radu_nicolae.pirea@....ro>,
        <nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <claudiu.beznea@...rochip.com>,
        <bcm-kernel-feedback-list@...adcom.com>, <fancer.lancer@...il.com>,
        <kernel@...gutronix.de>, <festevam@...il.com>, <linux-imx@....com>,
        <jbrunet@...libre.com>, <martin.blumenstingl@...glemail.com>,
        <avifishman70@...il.com>, <tmaimon77@...il.com>,
        <tali.perry1@...il.com>, <venture@...gle.com>, <yuenn@...gle.com>,
        <benjaminfair@...gle.com>, <yogeshgaur.83@...il.com>,
        <konrad.dybcio@...ainline.org>, <alim.akhtar@...sung.com>,
        <ldewangan@...dia.com>, <linux-aspeed@...ts.ozlabs.org>,
        <openbmc@...ts.ozlabs.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-sunxi@...ts.linux.dev>, <linux-tegra@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-wpan@...r.kernel.org>,
        <libertas-dev@...ts.infradead.org>,
        <linux-wireless@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <lars@...afoo.de>, <Michael.Hennerich@...log.com>,
        <linux-iio@...r.kernel.org>, <michael@...le.cc>,
        <palmer@...belt.com>, <linux-riscv@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <greybus-dev@...ts.linaro.org>, <linux-staging@...ts.linux.dev>,
        <amitrkcian2002@...il.com>
Subject: Re: [PATCH v2 04/13] iio: imu: Replace all spi->chip_select and
 spi->cs_gpiod references with function call



On 1/19/23 19:53, Amit Kumar Mahapatra wrote:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
> members of struct spi_device to be an array. But changing the type of these
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
> spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
> spi->cs_gpiod references with get or set API calls.
> While adding multi-cs support in further patches the chip_select & cs_gpiod
> members of the spi_device structure would be converted to arrays & the
> "idx" parameter of the APIs would be used as array index i.e.,
> spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.
> 
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>
> ---
>   drivers/iio/imu/adis16400.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c
> index c02fc35dceb4..3eda32e12a53 100644
> --- a/drivers/iio/imu/adis16400.c
> +++ b/drivers/iio/imu/adis16400.c
> @@ -466,7 +466,7 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev)
>   
>   		dev_info(&indio_dev->dev, "%s: prod_id 0x%04x at CS%d (irq %d)\n",
>   			indio_dev->name, prod_id,
> -			st->adis.spi->chip_select, st->adis.spi->irq);
> +			spi_get_chipselect(st->adis.spi, 0), st->adis.spi->irq);
>   	}
>   	/* use high spi speed if possible */
>   	if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) {

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal