netdev - Re: [PATCH next] wifi: nl80211: emit CMD_START_AP on multicast group when an AP is started

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <758384602b93da0f242ee5d82847a1b4ab102b91.camel@sipsolutions.net>
Date:   Tue, 24 Jan 2023 10:26:41 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc:     Alvin Šipraga <alvin@...s.dk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next] wifi: nl80211: emit CMD_START_AP on multicast
 group when an AP is started

Hi,

> > Seems like you should include the link ID or something?
> 
> Thanks for your review, you are quite right. I didn't give much thought
> to MLO as I am not too familiar with it. Is something like the below
> what you are looking for?

Yes, that looks good.

> Speaking of which: I drew inspiration from nl80211_send_ap_stopped()
> which see also doesn't include the link ID. Would you like me to include
> a second patch in v2 which adds the link ID to that function along the
> same lines?

Maybe have that as a separate patch, but yeah, good idea - thanks for
looking!

johannes