| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Jan 2023 17:42:01 +0800
From: kernel test robot <lkp@...el.com>
To: Leon Romanovsky <leon@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Steffen Klassert <steffen.klassert@...unet.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Leon Romanovsky <leonro@...dia.com>,
Andy Gospodarek <andy@...yhouse.net>,
Ayush Sawal <ayush.sawal@...lsio.com>,
Eric Dumazet <edumazet@...gle.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
intel-wired-lan@...ts.osuosl.org,
Jay Vosburgh <j.vosburgh@...il.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
netdev@...r.kernel.org, oss-drivers@...igine.com,
Paolo Abeni <pabeni@...hat.com>,
Raju Rangoju <rajur@...lsio.com>,
Saeed Mahameed <saeedm@...dia.com>,
Simon Horman <simon.horman@...igine.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
Veaceslav Falico <vfalico@...il.com>
Subject: Re: [PATCH net-next 10/10] cxgb4: fill IPsec state validation
failure reason
Hi Leon,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Leon-Romanovsky/xfrm-extend-add-policy-callback-to-set-failure-reason/20230123-220422
patch link: https://lore.kernel.org/r/9b45993fb96b6faa2b65f3dd78e677a54eeeec31.1674481435.git.leon%40kernel.org
patch subject: [PATCH net-next 10/10] cxgb4: fill IPsec state validation failure reason
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20230124/202301241750.Qpv1Vuj6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7eb8edee0c687243325ffd27b20c0f5d429b76f0
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Leon-Romanovsky/xfrm-extend-add-policy-callback-to-set-failure-reason/20230123-220422
git checkout 7eb8edee0c687243325ffd27b20c0f5d429b76f0
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:263:63: error: too few arguments provided to function-like macro invocation
NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead");
^
include/linux/netlink.h:127:9: note: macro 'NL_SET_ERR_MSG_MOD' defined here
#define NL_SET_ERR_MSG_MOD(extack, msg) \
^
>> drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:263:3: error: use of undeclared identifier 'NL_SET_ERR_MSG_MOD'
NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead");
^
2 errors generated.
vim +263 drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c
224
225 /*
226 * ch_ipsec_xfrm_add_state
227 * returns 0 on success, negative error if failed to send message to FPGA
228 * positive error if FPGA returned a bad response
229 */
230 static int ch_ipsec_xfrm_add_state(struct xfrm_state *x,
231 struct netlink_ext_ack *extack)
232 {
233 struct ipsec_sa_entry *sa_entry;
234 int res = 0;
235
236 if (x->props.aalgo != SADB_AALG_NONE) {
237 NL_SET_ERR_MSG_MOD(extack, "Cannot offload authenticated xfrm states");
238 return -EINVAL;
239 }
240 if (x->props.calgo != SADB_X_CALG_NONE) {
241 NL_SET_ERR_MSG_MOD(extack, "Cannot offload compressed xfrm states");
242 return -EINVAL;
243 }
244 if (x->props.family != AF_INET &&
245 x->props.family != AF_INET6) {
246 NL_SET_ERR_MSG_MOD(extack, "Only IPv4/6 xfrm state offloaded");
247 return -EINVAL;
248 }
249 if (x->props.mode != XFRM_MODE_TRANSPORT &&
250 x->props.mode != XFRM_MODE_TUNNEL) {
251 NL_SET_ERR_MSG_MOD(extack, "Only transport and tunnel xfrm offload");
252 return -EINVAL;
253 }
254 if (x->id.proto != IPPROTO_ESP) {
255 NL_SET_ERR_MSG_MOD(extack, "Only ESP xfrm state offloaded");
256 return -EINVAL;
257 }
258 if (x->encap) {
259 NL_SET_ERR_MSG_MOD(extack, "Encapsulated xfrm state not offloaded");
260 return -EINVAL;
261 }
262 if (!x->aead) {
> 263 NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead");
264 return -EINVAL;
265 }
266 if (x->aead->alg_icv_len != 128 &&
267 x->aead->alg_icv_len != 96) {
268 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with AEAD ICV length other than 96b & 128b");
269 return -EINVAL;
270 }
271 if ((x->aead->alg_key_len != 128 + 32) &&
272 (x->aead->alg_key_len != 256 + 32)) {
273 NL_SET_ERR_MSG_MOD(extack, "cannot offload xfrm states with AEAD key length other than 128/256 bit");
274 return -EINVAL;
275 }
276 if (x->tfcpad) {
277 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with tfc padding");
278 return -EINVAL;
279 }
280 if (!x->geniv) {
281 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states without geniv");
282 return -EINVAL;
283 }
284 if (strcmp(x->geniv, "seqiv")) {
285 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with geniv other than seqiv");
286 return -EINVAL;
287 }
288 if (x->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) {
289 NL_SET_ERR_MSG_MOD(extack, "Unsupported xfrm offload");
290 return -EINVAL;
291 }
292
293 sa_entry = kzalloc(sizeof(*sa_entry), GFP_KERNEL);
294 if (!sa_entry) {
295 res = -ENOMEM;
296 goto out;
297 }
298
299 sa_entry->hmac_ctrl = ch_ipsec_setauthsize(x, sa_entry);
300 if (x->props.flags & XFRM_STATE_ESN)
301 sa_entry->esn = 1;
302 ch_ipsec_setkey(x, sa_entry);
303 x->xso.offload_handle = (unsigned long)sa_entry;
304 try_module_get(THIS_MODULE);
305 out:
306 return res;
307 }
308
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists