netdev - Re: [PATCH net] xfrm/compat: prevent potential spectre v1 gadget in xfrm_xlate32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230124103857.GW665047@gauss3.secunet.de>
Date:   Tue, 24 Jan 2023 11:38:57 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Eric Dumazet <edumazet@...gle.com>
CC:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <eric.dumazet@...il.com>, Dmitry Safonov <dima@...sta.com>
Subject: Re: [PATCH net] xfrm/compat: prevent potential spectre v1 gadget in
 xfrm_xlate32_attr()

On Fri, Jan 20, 2023 at 01:02:49PM +0000, Eric Dumazet wrote:
>   int type = nla_type(nla);
> 
>   if (type > XFRMA_MAX) {
>             return -EOPNOTSUPP;
>   }
> 
> @type is then used as an array index and can be used
> as a Spectre v1 gadget.
> 
>   if (nla_len(nla) < compat_policy[type].len) {
> 
> array_index_nospec() can be used to prevent leaking
> content of kernel memory to malicious users.
> 
> Fixes: 5106f4a8acff ("xfrm/compat: Add 32=>64-bit messages translator")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Dmitry Safonov <dima@...sta.com>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>

Applied to the ipsec tree, thanks a lot Eric!