netdev - Re: [PATCH 00/12] can: rcar_canfd: Add support for R-Car V4H systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2023 12:02:23 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Ulrich Hecht <uli+renesas@...nd.eu>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 00/12] can: rcar_canfd: Add support for R-Car V4H systems

On Mon, Jan 23, 2023 at 07:56:02PM +0100, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series adds support for the CAN-FD interface on the Renesas
> R-Car V4H (R8A779G0) SoC and support for CAN transceivers described as
> PHYs to the R-Car CAN-FD driver.  It includes several fixes for issues
> (some minor) detected while adding the support and during testing.
> More details can be found in the individual patches.
> 
> Note that the last patch depends on "[PATCH 1/7] phy: Add
> devm_of_phy_optional_get() helper"[1].
> 
> This has been tested on the Renesas White-Hawk development board using
> cansend, candump, and canfdtest:
>   - Channel 0 uses an NXP TJR1443AT CAN transceiver, and works fine,
>   - Channels 1-7 use Microchip MCP2558FD-H/SN CAN transceivers (not
>     mounted for channels 4-7), which do not need explicit description.
>     While channel 1 works fine, channels 2-3 do not seem to work.
> 
> Hence despite the new fixes, the test results are similar to what Ulrich
> Hecht reported for R-Car V3U on the Falcon development board before,
> i.e. only channels 0 and 1 work (FTR, [2] does not help).
> Whether this is a CAN-FD driver issue, a pin control issue, an IP core
> issue, or an SoC integration issue is still to be seen...
> 
> 
> Thanks for your comments!

FWIIW this series looks clean to me:

Reviewed-by: Simon Horman <simon.horman@...igine.com>