netdev - Re: [PATCH net-next] devlink: remove a dubious assumption in fmsg dumping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2023 13:18:28 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next] devlink: remove a dubious assumption in fmsg
 dumping

Tue, Jan 24, 2023 at 04:52:31AM CET, kuba@...nel.org wrote:
>Build bot detects that err may be returned uninitialized in
>devlink_fmsg_prepare_skb(). This is not really true because
>all fmsgs users should create at least one outer nest, and
>therefore fmsg can't be completely empty.
>
>That said the assumption is not trivial to confirm, so let's
>follow the bots advice, anyway.
>
>This code does not seem to have changed since its inception in
>commit 1db64e8733f6 ("devlink: Add devlink formatted message (fmsg) API")
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>