netdev - Re: [PATCH net-next V2] net: fix kfree_skb_list use of skb_mark_not_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167453941816.4419.3173739226608329808.git-patchwork-notify@kernel.org>
Date:   Tue, 24 Jan 2023 05:50:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com,
        syzbot+c8a2e66e37eee553c4fd@...kaller.appspotmail.com
Subject: Re: [PATCH net-next V2] net: fix kfree_skb_list use of
 skb_mark_not_on_list

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 20 Jan 2023 11:34:44 +0100 you wrote:
> A bug was introduced by commit eedade12f4cb ("net: kfree_skb_list use
> kmem_cache_free_bulk"). It unconditionally unlinked the SKB list via
> invoking skb_mark_not_on_list().
> 
> In this patch we choose to remove the skb_mark_not_on_list() call as it
> isn't necessary. It would be possible and correct to call
> skb_mark_not_on_list() only when __kfree_skb_reason() returns true,
> meaning the SKB is ready to be free'ed, as it calls/check skb_unref().
> 
> [...]

Here is the summary with links:
  - [net-next,V2] net: fix kfree_skb_list use of skb_mark_not_on_list
    https://git.kernel.org/netdev/net-next/c/f72ff8b81ebc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html