[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BYAPR11MB3367BD0B7644182528FC599BFCCE9@BYAPR11MB3367.namprd11.prod.outlook.com>
Date: Wed, 25 Jan 2023 10:34:06 +0000
From: "G, GurucharanX" <gurucharanx.g@...el.com>
To: Bjorn Helgaas <helgaas@...nel.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH 4/9] i40e: Remove redundant
pci_enable_pcie_error_reporting()
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, January 19, 2023 5:16 AM
> To: linux-pci@...r.kernel.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@...el.com>; intel-wired-lan@...ts.osuosl.org; Bjorn
> Helgaas <bhelgaas@...gle.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Subject: [Intel-wired-lan] [PATCH 4/9] i40e: Remove redundant
> pci_enable_pcie_error_reporting()
>
> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver. Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this doesn't control interrupt generation by the Root Port; that is
> controlled by the AER Root Error Command register, which is managed by the
> AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Cc: Tony Nguyen <anthony.l.nguyen@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ----
> 1 file changed, 4 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)
Powered by blists - more mailing lists