netdev - Re: [PATCH v5 net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35f9613b-ac56-fdef-4020-af35b16321bb@linux.intel.com>
Date:   Wed, 25 Jan 2023 16:07:50 +0530
From:   "Kumar, M Chetan" <m.chetan.kumar@...ux.intel.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        johannes@...solutions.net, ryazanov.s.a@...il.com,
        loic.poulain@...aro.org, ilpo.jarvinen@...ux.intel.com,
        ricardo.martinez@...ux.intel.com,
        chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com,
        edumazet@...gle.com, pabeni@...hat.com,
        chandrashekar.devegowda@...el.com, linuxwwan@...el.com,
        linuxwwan_5g@...el.com,
        Mishra Soumya Prakash <soumya.prakash.mishra@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH v5 net-next 4/5] net: wwan: t7xx: Enable devlink based fw
 flashing and coredump collection

On 1/25/2023 10:23 AM, Jakub Kicinski wrote:
> On Sat, 21 Jan 2023 19:03:38 +0530 m.chetan.kumar@...ux.intel.com wrote:
>> 1> Driver Registers with Devlink framework.
>> 2> Implements devlink ops flash_update callback that programs modem fw.
>> 3> Creates region & snapshot required for device coredump log collection.
> 
> Sounds like these should be 3 patches?

Flashing and coredump feature implementation is kept under single
patch. I can revist and break it into 2 patches to seperate out
flashing and coredump logic. I hope this fine.

> 
>> +	devlink_params_register(dl_ctx, t7xx_devlink_params, ARRAY_SIZE(t7xx_devlink_params));
>> +	value.vbool = false;
>> +	devlink_param_driverinit_value_set(dl_ctx, T7XX_DEVLINK_PARAM_ID_FASTBOOT, value);
>> +	devlink_set_features(dl_ctx, DEVLINK_F_RELOAD);
>> +	devlink_register(dl_ctx);
> 
> Please take the devl_lock() explicitly and use the devl_
> version of those calls.

Ok. will modify it as per your suggestion.

-- 
Chetan