netdev - Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c582757f-a633-3958-d72e-e606e43879db@systemli.org>
Date:   Wed, 25 Jan 2023 12:26:14 +0100
From:   Nick <vincent@...temli.org>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Subject: Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks
 compilation with OpenWrt

Indeed, it is fixed by those patches. Thanks! Why are they still not merged?

On 1/25/23 00:28, Florian Fainelli wrote:
> On 12/27/22 07:23, Nick wrote:
>> Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces 
>> "-D_POSIX_C_SOURCE=200809L".
>> However, this breaks compilation with OpenWrt resulting in following 
>> error:
>>
>>> marvell.c: In function 'dump_queue':
>>> marvell.c:34:17: error: unknown type name 'u_int32_t'
>>>    34 |                 u_int32_t               ctl;
>>>       |                 ^~~~~~~~~
>> Not sure, why the code uses u_int32_t.
>
> Should be fixed with:
>
> https://lore.kernel.org/netdev/20230114163411.3290201-1-f.fainelli@gmail.com/T/ 
>