netdev - Re: bnxt devl_assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9FEXu1iyc4M8ODB@nanopsycho>
Date:   Wed, 25 Jan 2023 16:01:50 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Niklas Cassel <Niklas.Cassel@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: bnxt devl_assert_locked warning

Wed, Jan 25, 2023 at 03:41:43PM CET, Niklas.Cassel@....com wrote:
>On Wed, Jan 25, 2023 at 03:17:05PM +0100, Jiri Pirko wrote:
>> Wed, Jan 25, 2023 at 02:36:27PM CET, Niklas.Cassel@....com wrote:
>> >Hello there,
>> >
>> >When testing next-20230124 and next-20230125 I get a warning about devlink
>> >lock not being held in the bnxt driver, at boot or when modprobing the driver.
>> >See trace below.
>> >
>> >I haven't seen this when testing just 1-2 weeks ago, so I assume that something
>> >that went in recently caused this.
>> >
>> >Searching lore.kernel.org/netdev shows that Jiri has done a lot of refactoring
>> >with regards to devlink locking recently, could that be related?
>> 
>> Oh yeah, this is due to:
>> 63ba54a52c417a0c632a5f85a2b912b8a2320358
>> 
>> I just set a patches that is fixing this taking devlink instance lock
>> for params operations:
>> https://lore.kernel.org/netdev/20230125141412.1592256-1-jiri@resnulli.us/
>
>Thank you Jiri!
>
>I applied the series, and I can no longer see the warning during boot.

Great. Thanks for testing!


>
>Kind regards,
>Niklas