netdev - Re: [patch net-next 00/12] devlink: Cleanup params usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22ddf616-4df0-c558-2b38-43da1919040b@intel.com>
Date:   Wed, 25 Jan 2023 10:13:51 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <michael.chan@...adcom.com>,
        <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <tariqt@...dia.com>, <saeedm@...dia.com>, <leon@...nel.org>,
        <idosch@...dia.com>, <petrm@...dia.com>,
        <simon.horman@...igine.com>, <aelior@...vell.com>,
        <manishc@...vell.com>, <gal@...dia.com>,
        <yinjun.zhang@...igine.com>, <fei.qin@...igine.com>,
        <Niklas.Cassel@....com>
Subject: Re: [patch net-next 00/12] devlink: Cleanup params usage



On 1/25/2023 6:14 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> This patchset takes care of small cleanup of devlink params usage.
> Some of the patches (first 2/3) are cosmetic, but I would like to
> point couple of interesting ones:
> 

The cleanups are good!

> Patch 9 is the main one of this set and introduces devlink instance
> locking for params, similar to other devlink objects. That allows params
> to be registered/unregistered when devlink instance is registered.
> 

Makes sense.

> Patches 10-12 change mlx5 code to register non-driverinit params in the
> code they are related to, and thanks to patch 8 this might be when
> devlink instance is registered - for example during devlink reload.
> 

I like the cleanup/organization this allows by moving the parameter
registration closer to the code that parameter integrates with.

I read through the series and everything looks ok to me. Thanks for
cleaning up the ice driver!

The whole series is:

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Jiri Pirko (12):
>   net/mlx5: Change devlink param register/unregister function names
>   net/mlx5: Covert devlink params registration to use
>     devlink_params_register/unregister()
>   devlink: make devlink_param_register/unregister static
>   devlink: don't work with possible NULL pointer in
>     devlink_param_unregister()
>   ice: remove pointless calls to devlink_param_driverinit_value_set()
>   qed: remove pointless call to devlink_param_driverinit_value_set()
>   devlink: make devlink_param_driverinit_value_set() return void
>   devlink: put couple of WARN_ONs in
>     devlink_param_driverinit_value_get()
>   devlink: protect devlink param list by instance lock
>   net/mlx5: Move fw reset devlink param to fw reset code
>   net/mlx5: Move flow steering devlink param to flow steering code
>   net/mlx5: Move eswitch port metadata devlink param to flow eswitch
>     code
> 
>  drivers/net/ethernet/intel/ice/ice_devlink.c  |  20 +-
>  drivers/net/ethernet/mellanox/mlx4/main.c     |  80 ++---
>  drivers/net/ethernet/mellanox/mlx5/core/dev.c |  18 +-
>  .../net/ethernet/mellanox/mlx5/core/devlink.c | 283 +++++-------------
>  .../net/ethernet/mellanox/mlx5/core/devlink.h |   4 +-
>  drivers/net/ethernet/mellanox/mlx5/core/eq.c  |  12 +-
>  .../net/ethernet/mellanox/mlx5/core/eswitch.c |  10 +-
>  .../net/ethernet/mellanox/mlx5/core/eswitch.h |   4 +-
>  .../mellanox/mlx5/core/eswitch_offloads.c     |  92 +++++-
>  .../net/ethernet/mellanox/mlx5/core/fs_core.c |  84 +++++-
>  .../ethernet/mellanox/mlx5/core/fw_reset.c    |  44 ++-
>  .../ethernet/mellanox/mlx5/core/fw_reset.h    |   2 -
>  .../net/ethernet/mellanox/mlx5/core/main.c    |  22 +-
>  drivers/net/ethernet/mellanox/mlxsw/core.c    |  18 +-
>  .../net/ethernet/mellanox/mlxsw/spectrum.c    |  16 +-
>  .../ethernet/netronome/nfp/devlink_param.c    |   8 +-
>  .../net/ethernet/netronome/nfp/nfp_net_main.c |   7 +-
>  drivers/net/ethernet/qlogic/qed/qed_devlink.c |   6 -
>  drivers/net/netdevsim/dev.c                   |  36 +--
>  include/net/devlink.h                         |  20 +-
>  net/devlink/leftover.c                        | 185 ++++++------
>  21 files changed, 521 insertions(+), 450 deletions(-)
>