[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230124205356.2bd6683e@kernel.org>
Date: Tue, 24 Jan 2023 20:53:56 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: m.chetan.kumar@...ux.intel.com
Cc: netdev@...r.kernel.org, davem@...emloft.net,
johannes@...solutions.net, ryazanov.s.a@...il.com,
loic.poulain@...aro.org, ilpo.jarvinen@...ux.intel.com,
ricardo.martinez@...ux.intel.com,
chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com,
edumazet@...gle.com, pabeni@...hat.com,
chandrashekar.devegowda@...el.com, linuxwwan@...el.com,
linuxwwan_5g@...el.com,
Mishra Soumya Prakash <soumya.prakash.mishra@...el.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH v5 net-next 4/5] net: wwan: t7xx: Enable devlink based
fw flashing and coredump collection
On Sat, 21 Jan 2023 19:03:38 +0530 m.chetan.kumar@...ux.intel.com wrote:
> 1> Driver Registers with Devlink framework.
> 2> Implements devlink ops flash_update callback that programs modem fw.
> 3> Creates region & snapshot required for device coredump log collection.
Sounds like these should be 3 patches?
> + devlink_params_register(dl_ctx, t7xx_devlink_params, ARRAY_SIZE(t7xx_devlink_params));
> + value.vbool = false;
> + devlink_param_driverinit_value_set(dl_ctx, T7XX_DEVLINK_PARAM_ID_FASTBOOT, value);
> + devlink_set_features(dl_ctx, DEVLINK_F_RELOAD);
> + devlink_register(dl_ctx);
Please take the devl_lock() explicitly and use the devl_
version of those calls.
Powered by blists - more mailing lists