netdev - Re: [PATCH net-next] net: ethtool: provide shims for stats aggregation helpers when CONFIG_ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9JX2RU01Fgi+5GV@unreal>
Date:   Thu, 26 Jan 2023 12:37:13 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Michal Kubecek <mkubecek@...e.cz>,
        Andrew Lunn <andrew@...n.ch>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] net: ethtool: provide shims for stats
 aggregation helpers when CONFIG_ETHTOOL_NETLINK=n

On Wed, Jan 25, 2023 at 01:02:14PM +0200, Vladimir Oltean wrote:
> ethtool_aggregate_*_stats() are implemented in net/ethtool/stats.c, a
> file which is compiled out when CONFIG_ETHTOOL_NETLINK=n. In order to
> avoid adding Kbuild dependencies from drivers (which call these helpers)
> on CONFIG_ETHTOOL_NETLINK, let's add some shim definitions which simply
> make the helpers dead code.
> 
> This means the function prototypes should have been located in
> include/linux/ethtool_netlink.h rather than include/linux/ethtool.h.
> 
> Fixes: 449c5459641a ("net: ethtool: add helpers for aggregate statistics")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  drivers/net/ethernet/mscc/ocelot_stats.c |  1 +
>  include/linux/ethtool.h                  | 11 -------
>  include/linux/ethtool_netlink.h          | 42 ++++++++++++++++++++++++
>  3 files changed, 43 insertions(+), 11 deletions(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>