netdev - Re: [PATCH v3] netpoll: Remove 4s sleep during carrier detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4eaff461-47d1-cb9e-b24f-3699a77c3a3d@debian.org>
Date:   Thu, 26 Jan 2023 10:52:11 +0000
From:   Breno Leitao <leitao@...ian.org>
To:     David Laight <David.Laight@...LAB.COM>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     leit@...a.com, "leit@...com" <leit@...com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael van der Westhuizen <rmikey@...a.com>
Subject: Re: [PATCH v3] netpoll: Remove 4s sleep during carrier detection

On 26/01/2023 09:04, David Laight wrote:

>> This patch removes the msleep(4s) during netpoll_setup() if the carrier
>> appears instantly.
>>
>> Here are some scenarios where this workaround is counter-productive in
>> modern ages:
>>
>> Servers which have BMC communicating over NC-SI via the same NIC as gets
>> used for netconsole. BMC will keep the PHY up, hence the carrier
>> appearing instantly.
>>
>> The link is fibre, SERDES getting sync could happen within 0.1Hz, and
>> the carrier also appears instantly.
>>
>> Other than that, if a driver is reporting instant carrier and then
>> losing it, this is probably a driver bug.
> 
> I can't help feeling that this will break something.

If we see breakages after this patch, then we can identify broken 
drivers, and fix the driver itself.

On the other side, if we keep this workaround, we are penalizing the 
boot of every modern machine in 4s, just because we might have some 
broken driver somewhere.